[JENKINS-73539] Disable YUI by default #10045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
added
web-ui
|
Not sure if this is the right approach. The flag is a user specific thing, so when a plugin is installed that still requires YUI, it means that each and every user of that instance needs to enable it in their personal settings. |
6 tasks
timja
added
ath-successful
janfaracik
approved these changes
Dec 11, 2024
krisstern
approved these changes
Dec 11, 2024
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
comment-ops-bot
bot
added
the
ready-for-merge
|
good enough |
lets add just in case |
timja
added
the
upgrade-guide-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-73539.
This is the culmination of a lot of work over the years to slowly replace existing components that were built with YUI to alternatives.
A few examples:
A number of plugins and core changes have been prepared to make this possible.
See the tracking spreadsheet: https://docs.google.com/spreadsheets/d/1UjvtFmNmEdjMN5DUoFxJfBryA8q-E5_HwOzVKbVG9b0/edit?gid=969462704#gid=969462704
We aren't removing YUI at this time as @MarkEWaite requested that we wait till after the next LTS cutoff so-as vendors can change the default back if they still require YUI in their commercial products.
Testing done
Checked elements in the browser tools, by default no yui is there.
Disabled the flag in user settings and yui appears
Ran
System.setProperty("jenkins.model.experimentalflags.RemoveYuiUserExperimentalFlag.defaultValue", "false")in the script console and yui appears without having to set a flag.Clicked around and no issues found.
ATH is successful: jenkinsci/acceptance-test-harness#1861
PCT is successful: jenkinsci/bom#4084.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist